Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Workflow.connect_with docstring #1296

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Nov 28, 2023

The previous docstring was wrong. Using this opportunity to clarify the behavior and add an example in the docstring.

@PProfizi PProfizi added the documentation Improvements or additions to documentation label Nov 28, 2023
@PProfizi PProfizi self-assigned this Nov 28, 2023
Copy link

@FedericoNegri FedericoNegri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the doc, looks good to me.

Co-authored-by: JennaPaikowsky <98607744+JennaPaikowsky@users.noreply.github.com>
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #1296 (42ad719) into master (057bd32) will decrease coverage by 1.15%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1296      +/-   ##
==========================================
- Coverage   87.53%   86.39%   -1.15%     
==========================================
  Files          81       81              
  Lines        9236     9236              
==========================================
- Hits         8085     7979     -106     
- Misses       1151     1257     +106     

@PProfizi PProfizi merged commit f648231 into master Nov 28, 2023
36 checks passed
@PProfizi PProfizi deleted the doc/fix_workflow_connect_with_docstring branch November 28, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants